For more than a decade, modular construction companies promised they could save apartment developers time and money—cutting the overall cost of construction by as much as 30 percent.